Update E2E Test Consistency of Generated Data between logs/metrics/traces for eks/ec2 on java/python #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
approved these changes
May 14, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tency Update E2E Test Consistency of Generated Data between logs/metrics/traces for eks/ec2 on java/python
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tency Update E2E Test Consistency of Generated Data between logs/metrics/traces for eks/ec2 on java/python
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tency Update E2E Test Consistency of Generated Data between logs/metrics/traces for eks/ec2 on java/python
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…tency Update E2E Test Consistency of Generated Data between logs/metrics/traces for eks/ec2 on java/python
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
…jitter for initial Targets Poll (aws-observability#68) *Issue #, if available:* N/A *Description of changes:* - Use request Session object to be reused for getting sampling rules/targets - Use `with` locks to be consistent with lock usage - Add jitter for initial Targets Poll By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Followup from #65 and #41
In this PR, we make the data generated from the testing sample app more consistent between traces/metrics/logs.
Description of changes:
Make the inputted query-string to the sample app the same across the trace/metrics/logs validators.
Testing done:
15 minute canaries running successfully for 12+ hours:
EC2 Java in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-ec2-java.yml
EKS Java in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-eks-java.yml
EC2 Python in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-ec2-python.yml
EKS Python in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-eks-python.yml
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.